Skip to content

Conversation

@sinrohit
Copy link
Contributor

@sinrohit sinrohit commented Dec 8, 2024

Addresses #144 just for local packages. IFD will still be used for Hackage packages (callHackage) and custom source inputs.

Example: srid/haskell-template#146

@srid srid changed the title feat: IFD-less evalutation feat: cabal2nix integration for IFD-less evalutation Dec 16, 2024
@sinrohit sinrohit requested a review from srid December 16, 2024 19:41
@sinrohit sinrohit requested a review from srid December 16, 2024 20:07
Copy link
Owner

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As a last thing, could add a test?

@sinrohit sinrohit requested a review from srid December 19, 2024 18:23
Copy link
Owner

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just wanting on the other PRs to be merged. And then I'll test it on some of my projects before merging.

@srid srid force-pushed the cache-cabal2nix branch 3 times, most recently from f47c91a to 0327c07 Compare December 23, 2024 01:58
@srid srid merged commit d8a21e6 into srid:master Dec 23, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants